Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance accordion to support slugs and social sharing #109

Open
aniri opened this issue Mar 28, 2020 · 2 comments
Open

Enhance accordion to support slugs and social sharing #109

aniri opened this issue Mar 28, 2020 · 2 comments
Assignees
@moonflare
Labels
component enhancement New feature or request help wanted Extra attention is needed

Comments

@aniri
Copy link
Member

aniri commented Mar 28, 2020

Current version https://taskforce-fe-components.now.sh/?path=/story/accordion--default

Example of opened accordion element:
accordion_open

Wireframe: https://www.figma.com/file/xdKbESSX397obRR5m9DMM5/CoVid---who-is-who?node-id=0%3A1

It should use the https://taskforce-fe-components.now.sh/?path=/story/socials-share--with-url for social sharing.
@aniri aniri added enhancement New feature or request help wanted Extra attention is needed component labels Mar 28, 2020
@aniri aniri mentioned this issue Mar 28, 2020
Closed
@aniri aniri changed the title Enhance accordion to support slugs and sharing the link to it Enhance accordion to support slugs and social sharing Mar 28, 2020
@moonflare moonflare self-assigned this Mar 28, 2020
@alininayeh
Copy link
Contributor

Do you need help with this?

@moonflare
Copy link
Contributor

Hi @alininayeh. We're still discussing the expected functionality for this component. I will update the issue with a proper description once we decide how it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moonflare moonflare

Labels
component enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@moonflare @aniri @alininayeh