Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter the way the MailChimp Plugin is enabled & the key is retrieved #27

Open
2 tasks
tudoramariei opened this issue Aug 7, 2023 · 0 comments
Open
2 tasks
Labels

Comments

@tudoramariei
Copy link
Member

While this issue is two issues in one, we can't have one without the other, so they are both placed here.

  • use a feature flag instead of the MAILCHIMP_KEY
  • use the app interface to set the key

Use a feature flag for enabling the MailChimp plugin instead of using the actual key

The MailChimp plugin is enabled by checking if the MAILCHIMP_KEY variable has been passed.

MAILCHIMP_KEY = env("MAILCHIMP_KEY")
PLUGIN_MAILCHIMP_ENABLED = True if MAILCHIMP_KEY else False

Instead of the key, a feature flag should be used. This ensures that the key is not stored on the server and is not passed to the server owners.

Set and store the key in the application's interface

There already exists a field in the interface to store the MailChimp key.
That field should be the only point of adding the key and allow the responsible NGO personnel to change it.

Screenshot 2023-08-07 at 16 12 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant