fix 2 ARIA problems with speaker pages #43
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses two accessibility problems on the speakers and past keynotes pages.
aria-expanded
attributes of the speaker name links does not toggle, it simply stays "false" all the time even when a speaker's info box is displayedaria-controls
attributes target non-existent elementsSee MDN for
aria-expanded
reference. It's my understanding that the control must reflect the state of the controlled element, but the controlled element itself does not need any particular ARIA properties.To test:
aria-expanded
attribute should be "false"aria-controls
value should match theid
of the corresponding.speaker-info
box beneatharia-expanded
attribute should now be "true"aria-expanded
attribute should be "false"aria-expanded
attribute should be "true"Since these changes are to a speaker_box.html include they should fix both the past keynotes page and the regular speakers page http://127.0.0.1:4000/speakers/ but if you want to test that page, you first need to copy our example data (_data/examples/speakers.yml) into the _data directory.