fix(plugin-coverage): always include issues array, even if empty

code-pushup · May 23, 2024 · bd7c563 · bd7c563
1 parent a047ba9
commit bd7c563
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/...es/plugin-coverage/src/lib/runner/lcov/__snapshots__/lcov-runner.integration.test.ts.snap b/...es/plugin-coverage/src/lib/runner/lcov/__snapshots__/lcov-runner.integration.test.ts.snap
@@ -33,6 +33,9 @@ exports[`lcovResultsToAuditOutputs > should correctly convert lcov results to Au
     "value": 80,
   },
   {
+    "details": {
+      "issues": [],
+    },
     "displayValue": "100 %",
     "score": 1,
     "slug": "function-coverage",

diff --git a/packages/plugin-coverage/src/lib/runner/lcov/transform.ts b/packages/plugin-coverage/src/lib/runner/lcov/transform.ts
@@ -112,6 +112,8 @@ export function lcovCoverageToAuditOutput(
     score: toNumberPrecision(coverage, MAX_DECIMAL_PLACES),
     value: roundedIntValue,
     displayValue: `${roundedIntValue} %`,
-    ...(stat.issues.length > 0 && { details: { issues: stat.issues } }),
+    details: {
+      issues: stat.issues,
+    },
   };
 }
diff --git a/packages/plugin-coverage/src/lib/runner/lcov/transform.unit.test.ts b/packages/plugin-coverage/src/lib/runner/lcov/transform.unit.test.ts
@@ -304,6 +304,7 @@ describe('lcovCoverageToAudit', () => {
       score: 1,
       value: 100,
       displayValue: '100 %',
+      details: { issues: [] },
     });
   });
 
@@ -318,6 +319,7 @@ describe('lcovCoverageToAudit', () => {
       score: 1,
       value: 100,
       displayValue: '100 %',
+      details: { issues: [] },
     });
   });