fix(plugin-js-packages): always include issues array, even if empty

code-pushup · May 23, 2024 · 748eb64 · 748eb64
1 parent bd7c563
commit 748eb64
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/packages/plugin-js-packages/src/lib/runner/audit/transform.ts b/packages/plugin-js-packages/src/lib/runner/audit/transform.ts
@@ -25,7 +25,7 @@ export function auditResultToAuditOutput(
     score: calculateAuditScore(result.summary),
     value: result.summary.total,
     displayValue: summaryToDisplayValue(result.summary),
-    ...(issues.length > 0 && { details: { issues } }),
+    details: { issues },
   };
 }
 

diff --git a/packages/plugin-js-packages/src/lib/runner/audit/transform.unit.test.ts b/packages/plugin-js-packages/src/lib/runner/audit/transform.unit.test.ts
@@ -33,6 +33,7 @@ describe('auditResultToAuditOutput', () => {
       score: 1,
       value: 0,
       displayValue: '0 vulnerabilities',
+      details: { issues: [] },
     });
   });
 

diff --git a/packages/plugin-js-packages/src/lib/runner/outdated/transform.ts b/packages/plugin-js-packages/src/lib/runner/outdated/transform.ts
@@ -1,5 +1,5 @@
 import { ReleaseType, clean, diff, neq } from 'semver';
-import type { Issue } from '@code-pushup/models';
+import type { AuditOutput, Issue } from '@code-pushup/models';
 import { objectFromEntries, pluralize } from '@code-pushup/utils';
 import { DependencyGroup, PackageManagerId } from '../../config';
 import { dependencyGroupToLong } from '../../constants';
@@ -10,7 +10,7 @@ export function outdatedResultToAuditOutput(
   result: OutdatedResult,
   packageManager: PackageManagerId,
   depGroup: DependencyGroup,
-) {
+): AuditOutput {
   const relevantDependencies: OutdatedResult = result.filter(
     dep => dep.type === dependencyGroupToLong[depGroup],
   );
@@ -51,7 +51,7 @@ export function outdatedResultToAuditOutput(
     ),
     value: outdatedDependencies.length,
     displayValue: outdatedToDisplayValue(outdatedStats),
-    ...(issues.length > 0 && { details: { issues } }),
+    details: { issues },
   };
 }
 

diff --git a/packages/plugin-js-packages/src/lib/runner/outdated/transform.unit.test.ts b/packages/plugin-js-packages/src/lib/runner/outdated/transform.unit.test.ts
@@ -166,6 +166,7 @@ describe('outdatedResultToAuditOutput', () => {
       score: 1,
       value: 0,
       displayValue: 'all dependencies are up to date',
+      details: { issues: [] },
     });
   });
 
@@ -188,6 +189,7 @@ describe('outdatedResultToAuditOutput', () => {
       score: 1,
       value: 0,
       displayValue: 'all dependencies are up to date',
+      details: { issues: [] },
     });
   });