Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mode to Session Create Params typespec #660

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Add mode to Session Create Params typespec #660

merged 1 commit into from
Mar 16, 2021

Conversation

nthock
Copy link
Contributor

@nthock nthock commented Mar 16, 2021

mode is now required conditionally (or optional) when using prices in the line items. This PR will fix the failing dialyzer when including mode in the create_params.

Source: https://stripe.com/docs/api/checkout/sessions/create#create_checkout_session-mode

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.712% when pulling d6fc293 on nthock:master into dbff7f3 on code-corps:master.

snewcomer
snewcomer approved these changes Mar 16, 2021
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@snewcomer snewcomer merged commit ce0f23f into beam-community:master Mar 16, 2021
jalexander pushed a commit to Frameio/stripity_stripe that referenced this pull request Nov 20, 2024
@nthock @jalexander
Add mode to Session Create Params typespec (beam-community#660)
deea319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nthock @coveralls @snewcomer