Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use POST in cards/update API method #66

Merged
merged 2 commits into from
Aug 7, 2016
Merged

Use POST in cards/update API method #66

merged 2 commits into from
Aug 7, 2016

Conversation

gmile
Copy link
Contributor

@gmile gmile commented Aug 4, 2016

Fixes #63

@coveralls
Copy link

coveralls commented Aug 4, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 42.182% when pulling d87d592 on gmile:fix-for-issue-63 into 7a09ab8 on robconery:master.

@gmile gmile mentioned this pull request Aug 4, 2016
Closed
@nathany
Copy link

nathany commented Aug 4, 2016

Thanks @gmile!

Also not that there is no update_card/4 variant that doesn't require the Stripe key (as with add_card).

@gmile
Copy link
Contributor Author

gmile commented Aug 4, 2016

@nathany yeah, saw that inconsistency – all other methods I've seen have a pair. I'll add that tomorrow, along with a small chunk of docs for both.

@coveralls
Copy link

coveralls commented Aug 5, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 42.029% when pulling c62ae80 on gmile:fix-for-issue-63 into 7a09ab8 on robconery:master.

@gmile gmile mentioned this pull request Aug 5, 2016
Closed
@robconery robconery merged commit 00906f9 into beam-community:master Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmile @coveralls @nathany @robconery