Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds header as an option to new_request #654

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

subsetpark
Copy link
Contributor

Under certain circumstances, we expect headers to be passed in from above; thus we'd like to be able to look for headers in opts and merge into headers proper.

@coveralls
Copy link

coveralls commented Feb 22, 2021

Coverage Status

Coverage increased (+0.01%) to 90.256% when pulling fa0e350 on Frameio:add-idempotency-key into b0d1651 on code-corps:master.

This had to be done instead of extracting out the headers in options for
all functions that call request.
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this is a good idea!

@snewcomer snewcomer merged commit 2fe57a5 into beam-community:master Mar 6, 2021
jalexander pushed a commit to Frameio/stripity_stripe that referenced this pull request Nov 21, 2024
This had to be done instead of extracting out the headers in options for
all functions that call request.

Co-authored-by: Elijah Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants