Make subscription_data keys for Checkout optional #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to use the Stripe API without providing these keys. They are optional so we flag them as such to keep dialyzer happy. The Stripe docs indicate that only 'items' is required: https://stripe.com/docs/api/checkout/sessions/create#create_checkout_session-subscription_data
|
I'm not sure the best way to go about testing this. I'm very happy to try to add them if they are needed and if I could get some guidance? |
snewcomer
approved these changes
Apr 26, 2020
| :trial_period_days => integer() | ||
| optional(:metadata) => Stripe.Types.metadata(), | ||
| optional(:trial_end) => integer(), | ||
| optional(:trial_period_days) => integer() |
There was a problem hiding this comment.
looks like we have 3 new keys if you felt like adding! I'll merge in a few days if you haven't.
application_fee_percent
coupon
default_tax_rates
trail_from_plan
There was a problem hiding this comment.
I can look at doing that, sure!
There was a problem hiding this comment.
I've added the new fields. I don't now if that is all that is necessary? I guess the system just handles the new information without having to add additional code?
The types are based on: https://github.com/stripe/stripe-go/blob/b363a1c3d64708d837a96d32a498b59d6287ab7b/checkout_session.go#L98-L107 https://github.com/stripe/stripe-java/blob/13055f22a885379c24dcba11feba0ec38b1bf018/src/main/java/com/stripe/param/checkout/SessionCreateParams.java#L2393 Application Free Percent would ideally be something that is limited to postive values with maximum two decimal places but it seems like other APIs don't require that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to use the Stripe API without providing these keys. They
are optional so we flag them as such to keep dialyzer happy.
The Stripe docs indicate that only 'items' is required:
https://stripe.com/docs/api/checkout/sessions/create#create_checkout_session-subscription_data
Closes #568