Checkout Session retrieval and missing attributes #532
Conversation
nbw
changed the title
|
@nbw Mind rebasing with master? Also stripe api version will be configurable in 2.5! |
| @@ -66,13 +67,37 @@ defmodule Stripe.Session do | |||
| @type t :: %__MODULE__{ | |||
| :id => Stripe.id(), | |||
| :object => String.t(), | |||
| :livemode => boolean() | |||
| :cancel_url => boolean(), | |||
| :billing_address_collection => String.t(), | |||
There was a problem hiding this comment.
mind alpha ordering this?
There was a problem hiding this comment.
Done. Sorry, I followed the order in Stripe's docs. I sorted everything past object.
| :customer_email => String.t(), | ||
| :display_items => list(line_item), | ||
| :livemode => boolean(), | ||
| :locale => boolean(), |
There was a problem hiding this comment.
Looks like mode was added - https://stripe.com/docs/api/checkout/sessions/object
lib/stripe/checkout/session.ex
Outdated
| :payment_intent => String.t(), | ||
| :payment_method_types => list(String.t()), | ||
| :submit_type => String.t(), | ||
| :subscription => String.t(), |
There was a problem hiding this comment.
r/String.t()/Stripe.id() | Stripe.Subscription.t() | nil,
lib/stripe/checkout/session.ex
Outdated
| :display_items => list(line_item), | ||
| :livemode => boolean(), | ||
| :locale => boolean(), | ||
| :payment_intent => String.t(), |
There was a problem hiding this comment.
r/String.t()/Stripe.id() | Stripe.PaymentIntent.t() | nil,
lib/stripe/checkout/session.ex
Outdated
| :cancel_url => boolean(), | ||
| :billing_address_collection => String.t(), | ||
| :client_reference_id => String.t(), | ||
| :customer => String.t(), |
There was a problem hiding this comment.
r/String.t()/Stripe.id() | Stripe.Customer.t() | nil
Also add fallback defaults
|
Thanks. I rebased and implemented the requested changes. |
|
Lovely. thank you for the detailed commits! |
Summary
There are a number of attributes on the Sessions object that are missing. This PR adds any missing attributes mentioned in Stripe's docs.
There is also a retrieve endpoint that has since been added.
Tests
Added one test for Stripe.session.retrieve/2 following a pattern from
subscriptions_test.exs.Note
When I used the retrieve endpoint in my own project I had to add the header:
Stripe-Version:2019-05-16; checkout_sessions_beta=v1Edit: looks like that's already passed: https://github.com/code-corps/stripity_stripe/blob/1510f7c384cd3b3f40939d28a15a5bcdfe300aed/lib/stripe/api.ex#L19