Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Hackney options from config #506

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Pass Hackney options from config #506

merged 2 commits into from
Jul 12, 2019

Conversation

marcinbiegun
Copy link
Contributor

I've run into problems with timeouts (>5 seconds) coming from our Stripe test account.

The only piece of documentation regarding timeouts is here https://hexdocs.pm/stripity_stripe/Stripe.html#module-http-connection-pool But it doesn't change for how long the library waits for the server's response.

This change allows to set that timeout as additional opts for the Hackney HTTP client.

@coveralls
Copy link

coveralls commented May 28, 2019

Coverage Status

Coverage increased (+0.9%) to 87.241% when pulling 0e4c213 on marcinbiegun:hackney-opts-from-config into 43e3a39 on code-corps:master.

@snewcomer
Copy link
Collaborator

So while we are considering the best option, I just wanted to make sure that passing recv_timeout as the opts argument to any method will bump the time the http response time. If this is true, we probably want to document and let users know that if they want to do it on a per request basis, they can do so.

https://github.com/benoitc/hackney/blob/master/doc/hackney.md

@snewcomer snewcomer merged commit 7bec26b into beam-community:master Jul 12, 2019
@tylerwray
Copy link
Contributor

Any idea when this will get into a release? We're running into this problem quite a bit.

@snewcomer
Copy link
Collaborator

@tylerwray v2.5.0!

jalexander pushed a commit to Frameio/stripity_stripe that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants