Update file upload endpoint #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
commented
Nov 21, 2017
| file: "@/path/to/a/file.jpg", | ||
| purpose: "dispute_evidence" | ||
| }) | ||
| assert_stripe_requested :post, "/v1/files" |
There was a problem hiding this comment.
@joshsmith so perhaps these are failing is b/c it is files.stripe.com instead of api.stripe.com
There was a problem hiding this comment.
This test file didn't exist before
There was a problem hiding this comment.
ah found a request_file_upload method in Stripe.Request
snewcomer
changed the title
snewcomer
force-pushed
the
file-endpoint
branch
from
6672a8f
to
7cae938
Compare
snewcomer
changed the title
snewcomer
force-pushed
the
file-endpoint
branch
from
c05ca29
to
e9ad677
Compare
snewcomer
force-pushed
the
file-endpoint
branch
from
e9ad677
to
0f8f672
Compare
snewcomer
force-pushed
the
file-endpoint
branch
from
93c58d3
to
ca6b2b3
Compare
snewcomer
commented
Nov 21, 2017
| @@ -183,7 +178,7 @@ defmodule Stripe.API do | |||
| |> add_default_options() | |||
| |> add_pool_option() | |||
|
|
|||
| @http_module.request(method, req_url, req_headers, body, req_opts) | |||
| @http_module.request(method, req_url, req_headers, req_body, req_opts) | |||
There was a problem hiding this comment.
This is returning a 404
{:ok, 404,
[{"Stripe-Mock-Version", "master"}, {"Date", "Tue, 21 Nov 2017 06:05:38 GMT"},
{"Content-Length", "11"}, {"Content-Type", "text/plain; charset=utf-8"}],
"\"Not Found\""}
Hmmm. Wonder if the env variable is correct or actually need to reference a real file.
1 similar comment
|
This is blocked until we can figure out how to get the FileUpload API working with the OpenAPI spec. |
|
@snewcomer you'll need to rebase. I might run the |
snewcomer
force-pushed
the
file-endpoint
branch
from
ca6b2b3
to
65ca32c
Compare
6 similar comments
snewcomer
force-pushed
the
file-endpoint
branch
from
65ca32c
to
eb4d66a
Compare
joshsmith
force-pushed
the
file-endpoint
branch
from
eb4d66a
to
b7ebc83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awaiting response to this issue: stripe/stripe-mock#35