-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make API base url configurable #230
Conversation
@anronin are you using Bypass right now to test? |
yes, I'm testing it right now in my project and everything just fine |
Can you add some documentation for this and a test as well? |
Oh, I just realized this is a pull against |
yeah, in |
Docs would be helpful anyway, since we'll cut a release for hex. |
This is awesome, thanks @anronin! Just ran into this today |
1 similar comment
@joshsmith i've added docs, maybe anything else? |
Hey @anronin sorry for delay here. Will check it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Can you squash your commits down to one and then we can merge?
@anronin I've also invited you as a contributor now! Feel free to merge after that rebase/squash. |
@joshsmith nice! I'm not sure that I understand everything correctly, but it seems I do not have the right to merge. Right now I see this at the bottom:
|
Sorry, haven't seen the invite in the mail inbox :) |
Convenient when you need to test api calls, for example with the Bypass library