Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dialyzer and compiler warnings, bonus bugfix #212

Merged
merged 2 commits into from
Feb 11, 2017

Conversation

asummers
Copy link
Contributor

@asummers asummers commented Feb 9, 2017

Dialyzer was complaining about Stripe.invoice.update/3 because it was calling the update function with the wrong argument order. Fixed compiler warnings in tests while I was in here.

Since dialyzer is now 100% green, we should consider adding it to the CI pipeline. Any objections to that as a follow up to this PR? We should also consider enabling --warnings-as-errors for the compiler, it keeps people honest.

The argument order to Stripe.Request.update had the params in a
different order.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 26.027% when pulling 29f8425 on asummers:fix-dialyzer-warnings into f2d88da on code-corps:2.0.

@asummers asummers changed the title Fix dialyzer and compiler warnings Fix dialyzer and compiler warnings, bonus bugfix Feb 9, 2017
@begedin
Copy link
Contributor

begedin commented Feb 11, 2017

Merging this one. 2 commits, but they each are a "fix" of their own, so no reason to rebase. Good work.

@begedin begedin merged commit 797cab5 into beam-community:2.0 Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants