Fix dialyzer and compiler warnings, bonus bugfix #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialyzer was complaining about Stripe.invoice.update/3 because it was calling the update function with the wrong argument order. Fixed compiler warnings in tests while I was in here.
Since dialyzer is now 100% green, we should consider adding it to the CI pipeline. Any objections to that as a follow up to this PR? We should also consider enabling
--warnings-as-errors
for the compiler, it keeps people honest.