Add request helper to reduce duplication. #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage went down somehow, though this is the same code, more or less. This also suggests an obvious API change that I would like to propose -- making body be the first argument of
Stripe.Request
. In the case of e.g.update
, it would look like:I have this done locally and it looks pretty clean throughout. I can push to this branch if you all want, or a new one. This module would look like: https://gist.github.com/asummers/49384f353da45752b0cbb3ed61cbdc01 with
handle_result
being public because it is used inStripe.Card.create/4
.