Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stripe.Customer #117

Merged
merged 1 commit into from
Nov 11, 2016
Merged

Add Stripe.Customer #117

merged 1 commit into from
Nov 11, 2016

Conversation

joshsmith
Copy link
Contributor

Closes #112.

Adds create, retrieve, update, and delete capability for a Stripe.Customer.

Also fixes some minor bugs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 20.792% when pulling 98c3cf7 on 112-add-stripe-customer into ad0ed17 on 2.0.

@green-arrow
Copy link
Contributor

@joshsmith - looking over the Stripe documentation, it looks like in order to create an entity, you have to supply an object parameter, and I don't see that specified in any of the new stuff. Am I reading the docs right?

@DavidAntaramian
Copy link
Contributor

object parameters are not needed to create entities. They are only returned as part of the entity after creation.

@green-arrow
Copy link
Contributor

@DavidAntaramian - Ah woops, wrong issue. The documentation on the cards API marks object as being required, not here.

@joshsmith joshsmith merged commit ae5c995 into 2.0 Nov 11, 2016
@joshsmith joshsmith deleted the 112-add-stripe-customer branch November 11, 2016 16:43
@joshsmith joshsmith mentioned this pull request Nov 12, 2016
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshsmith @coveralls @green-arrow @DavidAntaramian