Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign of the OSD #773

Open
onolox opened this issue Feb 19, 2021 · 4 comments
Open

Redesign of the OSD #773

onolox opened this issue Feb 19, 2021 · 4 comments
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@onolox
Copy link

onolox commented Feb 19, 2021

PROBLEM:
The current OSD is functional, but can be better!

SOLUTION:
Make the OSDs appear like the native YT ones. Appear in the center of the video and with the same look and feel, maybe use the same code to gain animations.

ALTERNATIVES:
In a minimal approach, move the OSDs to the center of the video.

RELEVANCE / SCOPE:
I think in OSDs like volume and change in speed is important to have the visual feedback in the center because is the most important thing in the moment.

"SIDE EFFECTS":
Maybe an option with x and y to where the OSDs are postioned for the people that don't want to change.

Thank you all!

@onolox onolox added the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Feb 19, 2021
@ImprovedTube
Copy link
Member

Ola @onolox! :)
currently it reminds of old TV receivers showing channel number in top right, did they?
if "On Video Display":"centered" will be default option,
then should "top right" stay set for existing users who already set hotkeys?
(does anybody like top right? / got severely used to it?)

maybe optimal default will be:
centered but a little nearer to physical screen center
== a little lower from player's center
== neared to player's timebar,buttons,shadow
+Volume: a little left from center / nearer to youtube volume control.
+Speed: a little right / nearer to Youtube speed control

@tympapost
Copy link

I vote against centering the OSD.
There is a reason that all TVs have the OSD at a corner.
You need the visual feedback but not while obstructing your main focus (the video itself).

@onolox
Copy link
Author

onolox commented Feb 19, 2021

Yes keep the default to what is now, but an option to the ones who like to tweak :)
@tympapost When you change volume or speed you want to know what is the current value, this is most important than the video when you click the button(and for a second).
This is the motive that YT uses the centered feedback. You don't have to change your focus from the center. Corner OSD is more for things like don't need immediate feedback.

And my opinion is that every OSD feedback have to be positioned in the same spot, it creates a more robust pattern.

@ImprovedTube ImprovedTube added the Feature request Wish or idea label Apr 12, 2021
@ImprovedTube
Copy link
Member

tweak

we should probably restrucre ImprovedTube and have a menu section "advanced" with ~100 things & "extra tweaks" with even more while the top10 would fit on one screen / impossible to oversee

obstructing your main focus

besides interestingly screen center is usually not = video center and when you change something you are more conditioned to look down (player controls) than up

robust pattern.

thats why i said a little. yet are already conditioned to tend to look towards volume slider for volume
/ color white vs speed: crazy color.

nice to meet you @tympapost @onurdumangoz

@ImprovedTube ImprovedTube added good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants