Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery (and production) of small (~rare) but global features. #2037

Open
desteemy opened this issue Feb 22, 2024 · 7 comments
Open

Discovery (and production) of small (~rare) but global features. #2037

desteemy opened this issue Feb 22, 2024 · 7 comments
Assignees
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Knowledge Base / Dokumenation for developers We should repurpose this for future reference / Wiki / Education / Introduction Philosophy Solution exists (Here or 3rd party) Exists in any extension, userscript, webapp or app. Written in JS or not Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@desteemy
Copy link

desteemy commented Feb 22, 2024

(Edit by @ImprovedTube: originally this is/was a request for a feature we got in a different spot: "Allow the Play on TV button to be hidden". )


PROBLEM:

There is a button Play on TV in video player, which can be clicked accidentialy. Fortunately, first it will ask to which device should it cast. So it's not that bad as it used to be, where it immediately played a video on found TV. Some users might found this button will never be used.

Youtube does not provide functionality to dissable this button. Some browsers provide options to disable Casting globally by switching appropriate flag. Is it enough?

SOLUTION:

Adding switch that will hide and unhide Play on TV built-in button. There is a perfect place for this in already existing list Player -> Buttons as seen on the following screenshots:

ALTERNATIVES:

RELEVANCE / SCOPE:

By default the button Play on TV should be visible, because it is a built-in function, but I suspect at least 10% of users might find it useful.
There are threads requesting that feature on different devices posted on many websites:
https://support.google.com/chrome/thread/204292615/how-to-remove-google-cast-media-control-button-in-the-current-build?hl=en
https://support.google.com/youtubemusic/thread/202143057/how-do-i-turn-off-youtube-tv-casting?hl=en
https://support.google.com/chrome/thread/7163989/how-to-remove-the-cast-to-tv-button-from-my-android-device-for-youtube-and-google-chrome?hl=en
https://www.quora.com/Is-there-a-way-to-get-rid-of-the-cast-button-on-YouTube-so-that-I-stop-accidentally-taking-over-the-TV

"SIDE EFFECTS":

This functionality will edit built-in button visible on the video player, allowing the button to be removed and make UI more clear. So I believe it will be accepted well by people who take their time to look into extension settings.

CONTEXT:
//
Thank you!

SHORT Table (Summary)
Problem Annoying Play on TV button visible on video player UI
Solution Add switch that will hide/unhide this button
Alternatives
Scope 10%
Side effects 1%
Context
@desteemy desteemy added Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Feb 22, 2024
@BoazStassar
Copy link

@ImprovedTube Can i work on this?

@ImprovedTube
Copy link
Member

Thank you! @BoazStassar @desteemy

@ImprovedTube
Copy link
Member

I suspect at least 10% of users might find it useful.

yes, might be more among our users, besides extensions aren't most popular yet.

I believe it will be accepted well by people who take their time to look into extension settings.

check appearance: player: "hide player controls buttons" - we should add a copy of this button from menu/skeleton....appeance.js to the end of menu/skeleton...player.js

@ImprovedTube ImprovedTube added the Solution exists (Here or 3rd party) Exists in any extension, userscript, webapp or app. Written in JS or not label Feb 22, 2024
@ImprovedTube
Copy link
Member

..in sum, thanks for pointing out in one more way that our structure is important
please join discussing this topic & plans if you can / like:

@ImprovedTube ImprovedTube added the Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. label Feb 22, 2024
@ImprovedTube
Copy link
Member

next to structure for users, structure for volunteers / developers also matters.
(Such as the question: how could i have made us participate here first for example.)

#1445 (player buttons) #:~:text=chromecast

(Did you find 2037 because it was new & labeled up for grabs @BoazStassar?)

@ImprovedTube ImprovedTube added Knowledge Base / Dokumenation for developers We should repurpose this for future reference / Wiki / Education / Introduction Users-Documentation / HowTo We should repurse (some of) this thread to introduce users Philosophy and removed Feature request Wish or idea labels Feb 22, 2024
@ImprovedTube ImprovedTube changed the title Allow the Play on TV button to be hidden Discovery (and production) of small (~rare) but global features. Feb 22, 2024
@ImprovedTube
Copy link
Member

back to our feature ( hiding the TV button ), does it cover the apple equivalent?

@ImprovedTube ImprovedTube added Completion / Revision Rethink, complete, improve, tweak our feature or structure. and removed Users-Documentation / HowTo We should repurse (some of) this thread to introduce users labels Feb 22, 2024
ImprovedTube added a commit that referenced this issue Apr 3, 2024
Copied player settings  from appearance/player to the player menu (Fix to Issue #2037)
@ImprovedTube
Copy link
Member

thanks for caring! @BoazStassar

we can also have another link to Appearance:Player in bottom of the Player Section
and or endless scrolling (open end task)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Knowledge Base / Dokumenation for developers We should repurpose this for future reference / Wiki / Education / Introduction Philosophy Solution exists (Here or 3rd party) Exists in any extension, userscript, webapp or app. Written in JS or not Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants