Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default option for auto loop #1959

Closed
seriousgigi opened this issue Jan 24, 2024 · 6 comments
Closed

default option for auto loop #1959

seriousgigi opened this issue Jan 24, 2024 · 6 comments
Assignees
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@seriousgigi
Copy link

hello i think not making loopin videos for default option is kinda weird as the extension have lots of feature but not this.

you know i dont want to click loop button every time after opening a video/song. there should be setting to make looping default.

@seriousgigi seriousgigi added Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Jan 24, 2024
@kjonathan024
Copy link
Contributor

Hey! Mind if I take a look at this? I'm an undergraduate at the University of Florida looking for a first contribution and this looks manageable :)

@ImprovedTube ImprovedTube added Completion / Revision Rethink, complete, improve, tweak our feature or structure. Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. and removed Feature request Wish or idea labels Jan 24, 2024
@ImprovedTube
Copy link
Member

ImprovedTube commented Jan 24, 2024

hi!
@seriousgigi

@kjonathan024 awesome!(!! very many users appreciate this)

..so the feature exists, but needs to be updated: #1504


.. - and can be restructured somehow /easiest /clearest to find:

Our structure (Not to overwhelm. I don't know if you are a user too already):

  • (buttons repeat & loop should share the same code. it is one feature with multiple possible positions.)
  • separated menus for appearance and player are not perfect (have talked about this in a few old, open threads. Folders are static. We can get a proper search.
    • The appearance UI could appear on the front screen ("home").
    • We can keep all folders as legacy. But also have endless scrolling, just changing order. I.e.:
      • when opening the extension all features could appear ordered by popularity.
      • and when at player, scrolling below that, the next folder appearing could be appearance:player. Etc.
    • 37 of our features hide something. they could have their own list and own activation list called trash bin. together they are more than unhook (which has more users than us)

This topic might be a relevant experience, because efficiently finding features can be most important (the more software exists already, the more can be developed only to save each users a little time rarely). So chances are, to optimise the order/meaning of work, one can start reading open posts by maintainers /founders no matter how old (unless it is about latest news/updates/bugs with many thumbs up immediately). Also chances are, once you get going 2 or 3 tasks can be will be done, without increasing the work as much as the use /inspiration.

@kjonathan024
Copy link
Contributor

kjonathan024 commented Feb 5, 2024

@ImprovedTube how exactly do I go about building the extension from source? Say, I make a change to the code and want to install it on chrome to see if it works. (Edit: Nevermind I figured it out!)

@kjonathan024
Copy link
Contributor

@ImprovedTube I found a bug where when the repeat and loop buttons are both enabled, they do not sync up their appearances (greyed out or full opacity). I tried a simple fix of having them check the opacity / state of the other element, which seems to have solved that issue (as well as making sure both buttons are corresponding with the loop attribute of the player). Should I open up another ticket for this issue or can I add it as a PR for this ticket (once I've done some more testing)?

@kjonathan024
Copy link
Contributor

Linked to this pull request: #1990

@ImprovedTube
Copy link
Member

@ImprovedTube how exactly do I go about building the extension from source? Say, I make a change to the code and want to install it on chrome to see if it works. (Edit: Nevermind I figured it out!)

BTW https://github.com/code-charity/youtube/wiki/Contributing#developer-convenience-efficiency-methods

Developer convenience (/Efficiency /Methods)

  • Testing Browser-Extension changes with 1 click: Extension Reloader & enable the option to reload the current tab too & set a nice shortcut like alt+E chrome://extensions/shortcuts

    - Alternatively fully automatic: ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants