Shortcut for toggle player controls not working...

[clicky6]

Shortcut for toggle player controls not working.
Version-3.791
JSON file link - https://wormhole.app/a9ApP#XyS-WN5M2w4j27fm0iJ46A

[ghost]

Settings -> Backup & reset -> Export settings

[clicky6]

Settings -> Backup & reset -> Export settings

@victor-savinov
Then...

[ghost]

@clicky6 try to attach it here

[clicky6]

@clicky6 try to attach it here

@victor-savinov
GitHub wouldn't upload a .json file, So here is a link to the file.
https://wormhole.app/a9ApP#XyS-WN5M2w4j27fm0iJ46A

[clicky6]

@victor-savinov
Did you check what's wrong?

[ghost]

@clicky6 did not find a bug

[clicky6]

Looks like there was some problem with my settings only.
I reinstalled the extension, applied settings 1by1 and everything got fixed.

[Anoaxx]

Problem is its the problem with extension sometime stops changing options if u are change many of them on short time, especially shortcut, and secondly, if u focused on search bar in mean time, shortcuts somehow stops working...

[raszpl]

@clicky6 did it break again?

[clicky6]

@clicky6 did it break again?

Current Behavior:
When I hide the player controls using the set shortcut key, they reappear when I pause the video.

Expected Behavior:
The player controls should remain hidden until the shortcut key is pressed again.

[raszpl]

aaah, so the shortcut is technically working :=] , but the logic above fails. The pausing thing is a very important clue.

youtube/js&css/web-accessible/functions.js

Line 421 in 81f6888

ImprovedTube.playerOnPause = function (event) {

youtube/js&css/web-accessible/www.youtube.com/player.js

Line 1000 in 81f6888

ImprovedTube.playerControls = function () {

youtube/menu/skeleton-parts/appearance.js

Lines 234 to 248 in 81f6888

	player_hide_controls: {
	component: "select",
	text: "hidePlayerControlsBar",
	options: [{
	text: "off",
	value: "off",
	default: "true"
	}, {
	text: "whenPaused",
	value: "when_paused"
	}, {
	text: "always",
	value: "always"
	}]
	},

youtube/js&css/web-accessible/www.youtube.com/shortcuts.js

Lines 254 to 256 in 81f6888

	ImprovedTube.shortcutToggleControls = function () {
	if (this.elements.player) {
	this.storage.player_hide_controls = !this.storage.player_hide_controls;

ok so you cant actually just Toggle player controls because:

• our player_hide_controls has three states :)
• more importantly YT doesnt support forcing controls ON on playing video, instead it will show controls only with mouse cursor hovering over video

remedy is two step:

1. fixing shortcutToggleControls, done Update shortcuts.js fix shortcutToggleControls #1129 #2405
2. renaming "toggleControls"

   youtube/_locales/no/messages.json

   Lines 653 to 654 in 81f6888

   	"toggleControls": {
   	"message": "Toggle controls"

   
   to be consistent with

   youtube/_locales/en/messages.json

   Lines 650 to 651 in 81f6888

   	"hidePlayerControlsBar": {
   	"message": "Hide player controls bar"

   and say
   "Toggle player controls Hiding"

ill leave point 2 to someone else :)