Post-Judging QA

[thebrittfactor]

1. Please post feedback about specific findings on the relevant issue in this repo.
2. More general feedback for the judge can be shared here.

The judge for this contest is @fatherGoose1.

Reminders

• Please keep your comments as fact-based as possible.
• C4 judges have final authority in determining validity and severity.
• You are welcome to start new discussions here!
• Please link to specific issues wherever relevant.

Thank you!

[ustas-eth]

Good day, @fatherGoose1, and thank you for judging this contest!

Could you please provide a reason why these two findings were invalidated?
#843
#375

[ustas-eth]

@fatherGoose1 also this might be interesting in the context of Chainlink findings:
https://twitter.com/SiloFinance/status/1731013330716795038
https://twitter.com/zerosnacks/status/1731029905477878251

[osmanozdemir1]

Hi @fatherGoose1
Thanks for your efforts and judging this contest.
I left a comment on #372. Could you please take a look when you have time?
Thanks.

[Henrychang26]

Thank for judging @fatherGoose1,

I left a comment on #300

[DevHals]

Hi @fatherGoose1,

Thanks for judging the contest, I have left comments on:

• issue NodeDelegator.depositAssetIntoStrategy function doesn't check the returned shares amount by the strategy (lacks slippage control) #412
• issue Diluted rsETH price if the deposit pool received a direct LST asset transfer #413
• QA report QA Report #415

Thanks!

[DevHals]

Hi @fatherGoose1 ,
left another comment on issue #412, could you please check it?

[imsrybr0]

Hi @fatherGoose1,

Thank you for judging this contest.

Can you please check my comment on #353 ?

[imsrybr0]

Left another comment on #471 and #578

[thangtranth]

hi @fatherGoose1 ,

I left a comment on #479, please help to review.

Thanks for quick judging.

[shealtielanz]

Heyy @fatherGoose1
Thanks for your hard work as always on this contest.
I left my comment on #642

[TradMod]

Hey Judge @fatherGoose1 & sir @manoj9april!
I have left a comment on #230 (comment)
Thanks!

[TradMod]

Same Issue, new comment: #230 (comment)

[TradMod]

Sir pls take a final look at #412 (comment)

[serial-coder]

Hi @fatherGoose1,

Thanks for judging the contest, I have left comments on:

• Issue The stETH rebasing events lead to minting rsETH tokens incorrectly #711
• Issue Lacking validations leads to consuming stale or incorrect price data #689
• Issue Incorrect minting of rsETH tokens if LST asset price drops below Chainlink's minimum price #696

Thanks!

[SakshamGuruji3]

Hi @fatherGoose1 ,
left a comment on #829

Thanks!

[0xmahdirostami]

Thanks for judging @fatherGoose1,

I left a comment on #98

[0xmahdirostami]

Also left a comment on #99

[0xmahdirostami]

Also left a comment on #100

[blckhv]

Hi @fatherGoose1,

We added a comment to our QA report: #534

[Aamirusmani1552]

hey @fatherGoose1,
Thanks for judging the contest. I left a comment here: 865. Please check it.

[0xnirlin]

@fatherGoose1
Left a comment on #697

[T1MOH593]

Thanks for judging @fatherGoose1.
Left comment in #64

[adeolu98]

Hi @fatherGoose1 , I appreciate your efforts in judging this contest. I left a comment on #74.

[adeolu98]

i also left comments on #375, #354 and #468. thanks.

[0xbtk]

Thanks for judging @fatherGoose1, left comment in #788 and #808.

[0xbtk]

Hey @fatherGoose1, left a comment in #788.

[radeveth]

Hey, @fatherGoose1.

I left comments on: #645, #647, #197.

Thank you for the judging.
Have a good one!

[d3e4]

@fatherGoose1 I believe issue #584 has been misunderstood. I further believe the only valid and correct duplicates of this issue are #584 and #858. I left a comment on #584 explaining this.

[rodiontr]

Hi @fatherGoose1 ! Thanks for the judging. Left a comment on #140

[rodiontr]

Left another comment on #140

[Bauchibred]

Hi @fatherGoose1, thanks for judging, left comments on #347, #401 & #530.

[cryptostaker2]

Hi @fatherGoose1 , left a comment on #756. Thanks for judging!

[aslanbekaibimov]

Hello @fatherGoose1

I've left a comment on #62

Thank you!

[udsene]

Hi @fatherGoose1,

Thank you for quick judging of this contest !

I've left a comment on #736

[romeroadrian]

@fatherGoose1 nice to you see here. Left some comments on #828. Thanks!

[0xmahdirostami]

Thank for judging @fatherGoose1,

I left another comment on #98

[radeveth]

Hey, @fatherGoose1!

I left comment on report #700.

I appreciate all your efforts during the judging.
Have a good one!

[marchev]

Dear judge @fatherGoose1,

I have left a comment on report #215. Would appreciate your time and consideration.

Best,
Martin

[radeveth]

Hey, @fatherGoose1!

I've left my final thoughts for issue #645. Also, could you take a look at issue #197?
Please take a look and let me know your thoughts on them.

Have a good one!

[osmanozdemir1]

Hi, @fatherGoose1

Thanks for judging.
Issue #197 is just upgraded as satisfactory, and I left a comment regarding QA report #677, which includes a submission that is duplicate of #197.
Thanks