Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email template fixes #1567

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Email template fixes #1567

merged 2 commits into from
Aug 22, 2024

Conversation

ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Aug 21, 2024 •
edited
Loading

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

  • Codabench logo was not working in the emails, now fixed
  • Slight changes to the email text
  • Unsubscribe link removed because we don't have unsubscribe functionality

Issues this PR resolves

A checklist for hand testing

We need to deploy this change on codabench test for testing

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Aug 21, 2024 that may be closed by this pull request
Email sent has logo issue #1566
Closed
@Didayolo
Copy link
Member

@ihsaan-ullah Thanks for the PR. Why do we have for each email template a .html file and a .txt file with the same content?

@Didayolo Didayolo linked an issue Aug 21, 2024 that may be closed by this pull request
Email problems #1460
Closed
@ihsaan-ullah
Copy link
Collaborator Author

I missed some email templates. Now all ara changed

@ihsaan-ullah
Copy link
Collaborator Author

@ihsaan-ullah Thanks for the PR. Why do we have for each email template a .html file and a .txt file with the same content?

For some reason, both txt and html files are used to send the emails

codabench/src/utils/email.py

Line 9 in a37139a

def codalab_send_mail(context_data, to_email, html_file, text_file, subject, from_email=None):

@ihsaan-ullah ihsaan-ullah removed a link to an issue Aug 21, 2024
Email sent has logo issue #1566
Closed
@Didayolo Didayolo merged commit cf33e33 into develop Aug 22, 2024
1 check passed
@Didayolo
Copy link
Member

@ihsaan-ullah Deployed on codabench-test.lri.fr

@Didayolo Didayolo deleted the emails branch August 22, 2024 02:50
@ihsaan-ullah
Copy link
Collaborator Author

Emails sent to participants are working. For some reason I am not receiving admin emails (sent to organizers)

Screenshot 2024-08-22 at 11 05 16 AM Screenshot 2024-08-22 at 11 06 14 AM Screenshot 2024-08-22 at 11 06 50 AM

@ihsaan-ullah
Copy link
Collaborator Author

We can improve the email design in the future

@Didayolo Didayolo mentioned this pull request Sep 3, 2024
Merged
Didayolo added a commit that referenced this pull request Oct 11, 2024
@Didayolo @ihsaan-ullah
@OhMaley @ObadaS @bbearce
Rebase partners-logo (#1629)
983c8dc 
* autorun collectstatic when django container starts, added caddy_data and caddy_config to gitignore

* programs and datasets bug fixed

* if condition format fixed

* Downloading submissions witha stream v1

* updated toml file with python version and bpython version, deleted lock file, update dockerfile to not copy lock file and to generate lock file in the docker build

* Change base image for Dockerfile.flower (#1520)

* Change base image for Dockerfile.flower

* Remove platform argument

* Resources bundles dumps (#1505)

* Add a Bundles tab in Resources view

* add dump single and multiple deletion mechanism

* add competition title in bundle name + add competition link in bundle resource tab

* Update datasets.py (flake8)

---------

Co-authored-by: OhMaley <[email protected]>
Co-authored-by: Adrien Pavão <[email protected]>

* Improve formatting

* leaderboard api 500 error resolved (#1527)

* leaderboard api 500 error resolved

* flake issues resolved

* Changed submission name to add ID when downloading many submissions (#1565)

* changed submission name to add ID

* Flake8 white space fix

---------

Co-authored-by: Nicolas HOMBERG <[email protected]>

* Server Status:  submissions limit removed (#1562)

* server status submissions limit removed, pagination added, monitor queues separated

* renamed server status title to recent submissions

* Email template fixes (#1567)

* email logo fixed, some changes in email text

* participant side email templates updated

* task dataset/program removal fixed

* Updated docker-compose to docker compose

* whiltelist emails leaking fixed (#1560)

* competition whitelist feature added

* updated whitelist

* Update whitelist note

* whiltelist emails leaking fixed

* Remove conflict

---------

Co-authored-by: Adrien Pavão <[email protected]>

* Updates to server_status and monitor_queues (#1568)

* server_status and monitor_queues pages secured

* Update monitor_queues.html

* [Feature] Delete orphan files (#1575)

* Add button for orphan files deletion + API routes and views

* Fix flake8 formatting

---------

Co-authored-by: OhMaley <[email protected]>

* Fix string concat in case of no email in analytics api

* Poetry error tentative fix (#1588)

* Poetry error tentative fix

* RabbitMQ static image in Dockerfile.rabbitmq to fix a recent bug

* Reverted RabbitMQ image change

* Fix Rabbit version

---------

Co-authored-by: Obada Haddad <[email protected]>
Co-authored-by: didayolo <[email protected]>

* `Release PR#1` - Display release version in Codabench footer (#1583)

* release version added to header

* version moved to footer

* Minor UI change

---------

Co-authored-by: Adrien Pavão <[email protected]>

* `Release PR#2` Release version will load dynamically from version.json (#1592)

* release version added to header

* version moved to footer

* version on the website is now dynamic and will be loaded from the version.json file

---------

Co-authored-by: Adrien Pavão <[email protected]>

* `Release PR#3` created workflow for new releases (#1584)

* created workflow for new releases

* version json file added

* typo fix

* Update release-version-update.yml

* Included realease url to navigate user to the url on click on the website

* release json updated

---------

Co-authored-by: Obada Haddad <[email protected]>
Co-authored-by: Adrien Pavão <[email protected]>

* Updates Sept 15-22 2024 (#1593)

* jinja and pillow

* jinja and pillow

* Adding Versino_Bump_Instruction_README

* Version_Bumps file

* Version_Bumps file and req_treeFile updates

* gunicorn from 20.0.4 to 22.0.0

* Bump requests from 2.20.0 to 2.32.2

* Bump django from 2.2.17 to 2.2.18

* Bump django from 2.2.18 to 2.2.19 and to 3.2.25 eventually

* Bump django from 2.2.19 to 2.2.20

* Bump django from 2.2.20 to 2.2.25

* Bump django from 2.2.25 to 2.2.28

* Bump django from 2.2.25 to 2.2.28

* Version_Bumps.md text

* Update Dockerfile (upgrade Python)

* checking in some outstanding changes

* Remove Version Bumps

* removing version bumbs

---------

Co-authored-by: Adrien Pavão <[email protected]>

* organizers can now delete forum posts (#1613)

Co-authored-by: Adrien Pavão <[email protected]>

* bundles renamed to competition bundles, swapped postions of bundles and tasks (#1591)

Co-authored-by: Adrien Pavão <[email protected]>

---------

Co-authored-by: Ihsan Ullah <[email protected]>
Co-authored-by: Nicolas HOMBERG <[email protected]>
Co-authored-by: OhMaley <[email protected]>
Co-authored-by: Obada Haddad <[email protected]>
Co-authored-by: Obada Haddad-Soussac <[email protected]>
Co-authored-by: Benjamin Bearce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email problems
2 participants
@ihsaan-ullah @Didayolo