Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

programs and datasets bug fixed #1528

Merged
merged 3 commits into from
Jul 25, 2024
Merged

programs and datasets bug fixed #1528

merged 3 commits into from
Jul 25, 2024

Conversation

ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jul 13, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Files were not shown for competitions with tasks without ingestion and input data. Now that is fixed

NOTE

The logic of datasets and files are on the frontend here:

// Over complicated data org but it is so we can order exactly how we want...

This logic should be moved to the backend (In my opinion)

Issues this PR resolves

A checklist for hand testing

  • enable/disable programs and datasets and test that a participant can see them in files tab

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Jul 13, 2024 that may be closed by this pull request
@ihsaan-ullah
Copy link
Collaborator Author

@Didayolo this is ready to be merged. I have resolved the comment on the empty list

Rebase "programs_and_datasets" branch
@Didayolo Didayolo merged commit baa423a into develop Jul 25, 2024
1 check was pending
@Didayolo Didayolo deleted the programs_and_datasets branch July 25, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants