Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typo in the "Contributing" section #194

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Fix minor typo in the "Contributing" section #194

merged 1 commit into from
Oct 24, 2017

Conversation

shadyan
Copy link

@shadyan shadyan commented Oct 24, 2017

  • Changed "not" to "note" :)

Note: I wanted to add support for another language, but the current rules mechanism is a little limited when it comes to complex grammatical rules. Some things can only be (reasonably) done using regex. At one point I had about a thousand rules. Evaluating other approaches.

@florianeckerstorfer florianeckerstorfer merged commit b2834a0 into cocur:master Oct 24, 2017
@florianeckerstorfer
Copy link
Member

@shadyan Yes, me too. We decided on the simple rules approach because it is a lot faster than evaluating a list of regexp rules (like, really a lot faster). However, if you implement a custom slugifier while still implementing SlugifyInterface all the integrations still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants