-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Japanese support #46
Comments
All you need to do (If for some reason you can not make pull request) is:
Hope that helps |
+1 for the addition of the Japanese |
1 similar comment
+1 for the addition of the Japanese |
I gave it a try some months ago and it's more complicated to implement than Chinese. But I've stopped working on this because nobody was able help me understand why my Chinese pull request failed 2 checks, while it works perfectly (#158). |
Please, can you rebase your branch to |
Something like
Already transliterates some Japanese, although kanji is still very much an issue, It seem to just take the first reading it can find. A better option would probably be something like MeCab. Some example implementations: It does add a C++ dependency: https://github.com/taku910/mecab This could do a runtime check and keep current behaviour if it is not available, and enable it when mecab is available. |
I think that issue can be closed. |
Is there a way to get Japanese characters to work?
The text was updated successfully, but these errors were encountered: