Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/keyspan: refactor Truncate to not use filteringIter #3048

Closed
itsbilal opened this issue Nov 9, 2023 · 1 comment
Closed

internal/keyspan: refactor Truncate to not use filteringIter #3048

itsbilal opened this issue Nov 9, 2023 · 1 comment

Comments

@itsbilal
Copy link
Member

itsbilal commented Nov 9, 2023

Currently, keyspan.Truncate creates a filteringIter with a filter function. We uncovered a bug around certain uses of seeks in filteringIter in #3046 that forced us to add a check around Seek calls in the filteringIter, at the cost of one additional key comparison. If we refactored keyspan.Truncate to not use filteringIter, we could make that key comparison specific to just the Truncate case, and not other uses of filteringIter that don't mutate spans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants