Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable versions #2587

Closed
newhook opened this issue Jun 2, 2023 · 6 comments
Closed

stable versions #2587

newhook opened this issue Jun 2, 2023 · 6 comments
Labels
A-storage C-question Further information is requested T-storage

Comments

@newhook
Copy link

newhook commented Jun 2, 2023

Hey folks, we've started to use pebble as a replacement for the original go leveldb package. One issue is knowing what represents a stable release since there are no tagged versions. I see from earlier issues that using the crl-release-* branches was the recommendation. Is that still the case? Did you consider instead having tagged semver releases?

@nicktrav
Copy link
Contributor

nicktrav commented Jun 2, 2023

This is something we're going to take on for the Cockroach 23.2 release cycle (Fall '23). Stay tuned!

See also #1064.

@nicktrav nicktrav added the C-question Further information is requested label Jun 2, 2023
@jbowens
Copy link
Collaborator

jbowens commented Jun 2, 2023

One thing to be aware of: Pebble's durable format has been evolving over the years. By default, Pebble writes a database that's understandable by RocksDB (v6.2.1). The format is specified through Options.FormatMajorVersion, or it can be ratcheted up during runtime using DB.RatchetFormatMajorVersion. The current default is FormatMostCompatible (compatible with RocksDB v6.2.1), but eventually the default will be ratcheted up.

@newhook
Copy link
Author

newhook commented Jun 2, 2023

Thanks everyone. I know this is unrelated but is it possible to change from compressed to uncompressed format (or from snappy to something else) for an existing database.

Ie: change this configuration for an existing database without any explicit migration.

	// Disable compression to speed up the test.
	opts.EnsureDefaults()
	for i := range opts.Levels {
		opts.Levels[i].Compression = NoCompression
	}

@jbowens
Copy link
Collaborator

jbowens commented Jun 6, 2023

Yeah, if you open an existing database with different compression settings any new sstables created during flushes and compactions will be constructed using the new compression settings.

@martinarisk
Copy link

I would like stable tag too

@RaduBerinde
Copy link
Member

I just tagged a v1.0.0 release with the version that is part of CockroachDB 23.1.12.

I plan to tag a v1.1.0 release within the next months or so with the version that is part of CockroachDB 23.2.0 or .1.

Next version will be v2.0.0 and will correspond to CockroachDB 24.1. This version will no longer support older formats (including RocksDB and LevelDB).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage C-question Further information is requested T-storage
Projects
Archived in project
Development

No branches or pull requests

5 participants