Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it acceptable for features SSTable partitioner and compaction filter #1676

Open
hicqu opened this issue Apr 29, 2022 · 4 comments
Open

Is it acceptable for features SSTable partitioner and compaction filter #1676

hicqu opened this issue Apr 29, 2022 · 4 comments

Comments

@hicqu
Copy link

hicqu commented Apr 29, 2022

I'm working with pebble in my project now and thank you for this wonderful library. I want to introduce 2 RocksDB things into pebble:

I'm not sure whether they conflict with other things you are working on. I hope they are acceptable and I can give a try if so.

Jira issue: PEBBLE-95

@jbowens
Copy link
Collaborator

jbowens commented Apr 29, 2022

Hi @hicqu, great to hear you're using and enjoying Pebble! We would welcome both of those extensions. If you want to take these on, I suggest sketching out an implementation design in this issue first, and we can discuss.

I'm not sure whether they conflict with other things you are working on.

The one thing that comes to mind is ranged keys (design in #1341). That project doesn't fundamentally conflict, but we'll be integrating these "ranged keys" into compactions in the next few weeks. There is some potential for conflicts as we consider refactors of the compaction logic to fit range keys.

@hicqu
Copy link
Author

hicqu commented May 5, 2022

@jbowens thanks for your information. I will try to send a RFC PR later.

@aierui
Copy link

aierui commented Feb 13, 2023

ping @hicqu

@gawen
Copy link

gawen commented Dec 20, 2024

ping @hicqu . interested in the compaction filter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

4 participants