-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time-series metrics re: LSM state #1140
Comments
Pebble already exports this info at a very fine granularity. See https://github.com/cockroachdb/pebble/blob/master/metrics.go#L125. Pebble itself doesn't create any timeseries metrics, it only ever exports data that can be used to power metrics at an application level. I suspect there is nothing to be done here in Pebble. |
Nice. So then this is a CRDB issue, @petermattis? I'll look for the time-series metrics first. |
Closing in favor of cockroachdb/cockroach#65276. |
Stats like count & size make fantastic time-series metrics:
My understanding is the number of levels doesn't grow forever, so we can break the metrics down by level without worry about carnality limits.
It'll be much quicker to make basic sense of what is going with such metrics. Logs are good too but metrics can be made sense of at higher speed. Also, it is easier to correlate such metrics with some impact based metrics (SQL latencies or
kvprober
error rate) than it is to do so with logs.This will compliment #1141.
The text was updated successfully, but these errors were encountered: