From be1586403c9bdf0c6a97074f2762758a66f68806 Mon Sep 17 00:00:00 2001 From: Arjun Nair Date: Sat, 16 Sep 2023 02:13:55 -0400 Subject: [PATCH] manifest: remove invalid comment --- internal/manifest/version.go | 7 ------- 1 file changed, 7 deletions(-) diff --git a/internal/manifest/version.go b/internal/manifest/version.go index 17ed348f0e..0c75b13e92 100644 --- a/internal/manifest/version.go +++ b/internal/manifest/version.go @@ -169,13 +169,6 @@ type FileMetadata struct { // FileNum is the file number. // // INVARIANT: when !FileMetadata.Virtual, FileNum == FileBacking.DiskFileNum. - // - // TODO(bananabrick): Consider creating separate types for - // FileMetadata.FileNum and FileBacking.FileNum. FileNum is used both as - // an indentifier for the FileMetadata in Pebble, and also as a handle to - // perform reads and writes. We should ensure through types that - // FileMetadata.FileNum isn't used to perform reads, and that - // FileBacking.FileNum isn't used as an identifier for the FileMetadata. FileNum base.FileNum // Size is the size of the file, in bytes. Size is an approximate value for // virtual sstables.