Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-7610 drop preview for schedule options in CREATE SCHEDULE #16911

Merged
merged 2 commits into from
May 15, 2023
Merged

DOC-7610 drop preview for schedule options in CREATE SCHEDULE #16911

merged 2 commits into from
May 15, 2023

Conversation

ashleykwtam
Copy link
Contributor

@ashleykwtam ashleykwtam commented May 9, 2023 •
edited
Loading

Addresses DOC-7610:

  • Drop the preview warning in schedule options as we do not consider these options in preview mode anymore

Preview:

@netlify
Copy link

netlify bot commented May 9, 2023 •
edited
Loading

✅ Netlify Preview

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a1cca6
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6462295d6bbf100008015af3
😎 Deploy Preview https://deploy-preview-16911--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ashleykwtam ashleykwtam requested a review from adityamaru May 9, 2023 16:48
@ashleykwtam ashleykwtam requested a review from kathancox May 10, 2023 13:30
kathancox
kathancox approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@kathancox kathancox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if @livlobo has OK'd 👍

@ashleykwtam
Copy link
Contributor Author

Yes Liv confirmed via Slack it is good to drop the tags as she hasn't heard anything from customers

@ashleykwtam ashleykwtam merged commit 5b45abb into cockroachdb:master May 15, 2023
@ashleykwtam ashleykwtam deleted the DOC=7610-drop-preview-tag-show-schedules branch May 15, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathancox kathancox kathancox approved these changes

@adityamaru adityamaru adityamaru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleykwtam @adityamaru @kathancox