Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logconfig: support YAML arrays to configure channels #9737

Closed
jseldess opened this issue Feb 9, 2021 · 3 comments
Closed

logconfig: support YAML arrays to configure channels #9737

jseldess opened this issue Feb 9, 2021 · 3 comments
Assignees
Milestone

Comments

@jseldess
Copy link
Contributor

jseldess commented Feb 9, 2021

PR: cockroachdb/cockroach#59352

From release notes:

  • The channels parameter for the log sink configurations now supports a more flexible input configuration format:
    Syntax to include specific channels:
    channels: dev,sessions (yaml string)
    channels: 'dev,sessions' (yaml string, equivalent to previous)
    channels: [dev,sessions] (yaml array, can use multi-line syntax with hyphens too)
    channels: ['dev','sessions'] (same as previous)
    channels: '[dev,sessions]' (bracket-enclosed list inside yaml string)

    Syntax to include all channels:
    channels: all (yaml string)
    channels: 'all' (same as previous)
    channels: [all] (yaml array)
    channels: ['all'] (same as previous)
    channels: '[all]' (bracket-enclosed "all" inside yaml string)

    Syntax to include all channels except some:
    channels: all except dev,sessions (yaml string)
    channels: 'all except dev,sessions' (same as previous, quoted string)
    channels: 'all except [dev,sessions]' (same as previous, list is bracket enclosed)

    For example: sinks: stderr: channels: - DEV - SQL_SESSIONS uses the "native" YAML syntax for lists. [#59352][#59352]

@jseldess
Copy link
Contributor Author

jseldess commented Feb 9, 2021

@taroface, @mikeCRL, not sure who this fall to.

@taroface
Copy link
Contributor

taroface commented Feb 9, 2021

I can take this.

@taroface
Copy link
Contributor

Closed by #10273.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants