Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining high-latency items from "overhead" bucket and differentiate them #7752

Closed
ericharmeling opened this issue Jul 16, 2020 · 7 comments
Assignees
Labels
P-1 High priority; must be done this release
Milestone

Comments

@ericharmeling
Copy link
Contributor

https://cockroachlabs.atlassian.net/browse/CRDB-402

@taroface @awoods187
This roadmap item is on the SQL JIRA board, but I think it's more relevant to admin UI docs rather than SQL docs.

@ericharmeling ericharmeling added C-roadmap P-1 High priority; must be done this release labels Jul 16, 2020
@ericharmeling ericharmeling added this to the 20.2 milestone Jul 16, 2020
@awoods187
Copy link
Contributor

Adding this comment from the other issue:

Well let's talk about this in our meeting. These are definitely a part of the SQL Product Area even if they touch the webui so we'd definitely need to track them in this project. However, if they should be done by another writer who works with the UI, then we can assign it to that writer but keep it in this project. Let's talk more about it.

@jseldess
Copy link
Contributor

@ericharmeling, it's ok that multiple writers will start touching UI docs. This is similar to CC, where writers are contributing to docs depending on the product area. Let's have you try documenting UI changes coming from your area. You can discuss and coordinate with @taroface.

@ericharmeling
Copy link
Contributor Author

ericharmeling commented Oct 7, 2020

@awoods187

The JIRA epic for this (https://cockroachlabs.atlassian.net/browse/CRDB-402) has the feature marked a "In review/testing". Is this feature complete for v20.2? I haven't seen any docs release note issues for it.

Also, the overhead bucket, and other latency stats appear to be documented, thanks to #6821 from @taroface .

@taroface taroface assigned taroface and unassigned ericharmeling Oct 7, 2020
@awoods187
Copy link
Contributor

This is part of the enhancements to statements and transaction pages. @solongordon can you confirm this work is complete?

@taroface
Copy link
Contributor

@solongordon ping on the above question!

@taroface
Copy link
Contributor

taroface commented Nov 6, 2020

Per @solongordon the fix that had been committed was later reverted. There is some work pending on this.

@taroface taroface modified the milestones: 20.2, Later Nov 6, 2020
@awoods187
Copy link
Contributor

cockroachdb/cockroach#40675 is being worked on to re-address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-1 High priority; must be done this release
Projects
None yet
Development

No branches or pull requests

4 participants