Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create how-to on shutting down a node #6951

Closed
jseldess opened this issue Mar 23, 2020 · 6 comments
Closed

Create how-to on shutting down a node #6951

jseldess opened this issue Mar 23, 2020 · 6 comments
Assignees
@taroface
Labels
C-doc-improvement O-eng P-1 High priority; must be done this release T-incorrect-or-unclear-info T-missing-info
Milestone
20.2

Comments

@jseldess
Copy link
Contributor

jseldess commented Mar 23, 2020 •
edited by exalate-issue-sync bot
Loading

Jesse Seldess (jseldess) commented:

We are overloading the cockroach quit command to double as command reference and broader explanation of the process of shutting down a node. Instead, we should have a distinct page, Stop a node, that explains best practices and exactly what happens during the shut down process, and how to do it.

Jira Issue: DOC-466
@knz
Copy link
Contributor

knz commented Mar 23, 2020 •
edited
Loading

xref: https://cockroachlabs.slack.com/archives/CA8H95NUU/p1583778076005900
xref: cockroachdb/cockroach#45149
xref: cockroachdb/cockroach#46396

@mattcrdb mattcrdb mentioned this issue Mar 26, 2020
Closed
@knz
Copy link
Contributor

knz commented Mar 31, 2020

update on this: the new flag --only-drain to cockroach quit introduced in cockroachdb/cockroach#45149 now reports a progress indicator, which can be used to determine when it's safe to stop the process.

@jseldess jseldess mentioned this issue Apr 1, 2020
Merged
@jseldess jseldess added this to the 20.2 milestone Apr 27, 2020
@taroface
Copy link
Contributor

taroface commented May 27, 2020 •
edited
Loading

Relates to #7422

  • Add links to this article from remove-nodes.md, cockroach-quit.md, planned-maintenance.md.
  • Remove mentions of cockroach quit in docs.

Edit: This article should convey the shutdown nuances described here:

  • Description of a successful shutdown (prior to restart)
  • What to do if things take too much time?
    • (How much time is too much time?)

@jseldess jseldess mentioned this issue Jun 9, 2020
Closed
@taroface taroface added the P-1 High priority; must be done this release label Jun 10, 2020
@irfansharif
Copy link
Contributor

The discussion that ensued in cockroachdb/cockroach#48339 may be of interest here. It discusses possible improvements wrt teaching our users on how they should go about thinking about node shut downs.

This was referenced Jul 28, 2020
Merged
Open
@irfansharif irfansharif mentioned this issue Sep 8, 2020
Closed
@taroface
Copy link
Contributor

taroface commented Nov 1, 2021 •
edited
Loading

Related: #9009

Also this thread: https://cockroachlabs.slack.com/archives/C01PHNMUFLN/p1635774345034000

@exalate-issue-sync
Copy link

Michael Wang (mwang1026) commented:
Duplicate of recent node shutdown improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taroface taroface

Labels
C-doc-improvement O-eng P-1 High priority; must be done this release T-incorrect-or-unclear-info T-missing-info
Projects
None yet
Milestone
20.2
Development

No branches or pull requests
4 participants
@knz @taroface @irfansharif @jseldess