Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: add support for aggregate FILTER #4365

Closed
jseldess opened this issue Feb 12, 2019 · 2 comments
Closed

opt: add support for aggregate FILTER #4365

jseldess opened this issue Feb 12, 2019 · 2 comments
Assignees
Labels
C-product-change P-1 High priority; must be done this release
Milestone

Comments

@jseldess
Copy link
Contributor

PR: cockroachdb/cockroach#34077

From release notes:

FILTER expressions are now supported by the cost-based optimizer. [#34077][#34077] {% comment %}doc{% endcomment %}

@jseldess jseldess added this to the 2.2 milestone Feb 12, 2019
@jseldess
Copy link
Contributor Author

@rmloveland, does the unsupported statement error here need to be changed given the above? https://www.cockroachlabs.com/docs/v2.2/cost-based-optimizer.html#view-query-plan

@jseldess jseldess added A-sql P-1 High priority; must be done this release labels Feb 13, 2019
@jseldess jseldess modified the milestones: 2.2, 19.1 Feb 25, 2019
@rmloveland
Copy link
Contributor

@rmloveland, does the unsupported statement error here need to be changed given the above? https://www.cockroachlabs.com/docs/v2.2/cost-based-optimizer.html#view-query-plan

Yes. I considered doing a small PR right now, but I have issues #4366 and friends which mean that section will need a full rewrite anyway due to all of the various EXPLAIN changes. The smaller PR now would be wasted work (and may also lead to merge conflicts since this page is beginning to have many things on it ^_^ )

The docs that state we support the feature from this issue were added in commit 7fbce7b so I'll close this one and let the erroneous text be washed away by those other impending work items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-product-change P-1 High priority; must be done this release
Projects
None yet
Development

No branches or pull requests

2 participants