Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #103945 - jobs: add a Profiler tab to the job details page #17288

Closed
cockroach-teamcity opened this issue Jun 16, 2023 · 5 comments
Closed

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jun 16, 2023

Exalate commented:

Related PR: cockroachdb/cockroach#103945
Commit: cockroachdb/cockroach@acd6d23
Fixes: CRDB-27623


Release note (ui change): job details page now has a
profiler tab for more advanced observability into a job's
execution. Currently, we support collecting a cluster-wide
CPU profile of the job.

Jira Issue: DOC-8123

Copy link

Florence Morris (florence-crl) commented:
Hi Aditya Maru When I click on Advanced Debugging tab, I see 2 files listed under Execution Detail Files. I did not click the Profile link or the Request Execution Details button, so I do not expect those 2 files to be there. Is this a bug?

!Screenshot 2023-11-16 at 1.56.25 PM.png|width=1069,height=681!

Copy link

Aditya Maru (adityamaru) commented:
Hey Florence Morris no this is working as expected. In some cases we expect to see files there even when they are not requested. I apologize for adding the release not in the PR, this tab is supposed to be undocumented for the upcoming release and only to be used by developers and support. I don’t think we need to add any documentation here.

Copy link

Florence Morris (florence-crl) commented:
Kevin Ngo Is it ok to mark this as “Done, Won’t Do”?

Copy link

Kevin Ngo (kevin-v-ngo) commented:
I originally marked this as High because this is surfaced on the Jobs page (not the Advanced Debug) page. It seems similar to Statement bundles and Debug.zip which we document pretty extensively for TSEs as well when troubleshooting with customers. Aditya Maru do we only expect L2 to use this profile tab?

Copy link

Aditya Maru (adityamaru) commented:
Yes for 23.2 we only expect L2 to recommend to TSE how to use this file. I don’t think this page is as ready as Statement Bundles or debug zips. I think this should be doc’ed as internal runbooks but not user facing until we polish it up and get some mileage on how we plan to use it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants