Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: util/log,server/debug: fixes to logging and the logspy api endpoint #11075

Open
mikeCRL opened this issue Aug 18, 2021 · 1 comment
Milestone

Comments

@mikeCRL
Copy link
Contributor

mikeCRL commented Aug 18, 2021

Michael Lewis (mikeCRL) commented:

PR: cockroachdb/cockroach#66328

From release notes:

When log entries are written to disk, the first few header lines written at the start of every new file now report the configured [logging format](../v21.1/log-formats.html]. [#66328][#66328) {% comment %}doc{% endcomment %}

Jira Issue: DOC-1469

@mikeCRL mikeCRL added this to the 21.1 milestone Aug 18, 2021
@exalate-issue-sync exalate-issue-sync bot changed the title release-21.1: util/log,server/debug: fixes to logging and the logspy api endpoint release-21.1: util/log,server/debug: fixes to logging and the logspy api endpoint Feb 1, 2022
@exalate-issue-sync exalate-issue-sync bot assigned andf-crl and unassigned taroface Jun 10, 2022
@exalate-issue-sync
Copy link

Andrew Feierabend (andf-crl) commented:
So, this ticket is meant to reflect this PR: cockroachdb/cockroach#65633predominantly: the other bundled PRs in the linked PR are already addressed (as docs no-ops) in DOCS-[1466-1468].

Aside: it’s funny to receive this DOCS ticket, as I made this CRDB issue back in July: cockroachdb/cockroach#84401!

Anyways, the linked PR appears to have first appeared in {{v21.2}}(according to GitHub Refined). I stumbled upon https://cockroachlabs.atlassian.net/browse/DOC-4887 , which is explicitly a backport to v21.2 of the same release note description, suggesting that it might be a duplicate. I also see a reference to “supposed to make it into 21.2, but it never did” with some interesting context to cockroachdb/cockroach#83748.

Probably this should be closed in favor of https://cockroachlabs.atlassian.net/browse/DOC-4887; will revisit post-22.2 GA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants