server: ignore spanconfig limit for shared-process tenants #99918
Conversation
This change installs a noop spanconfig limiter when starting shared-process tenants. Since shared-process tenants are currently used for "unified architecture" in which the tenant is expected to behave as close as possible to the system tenant. When we have a tenant-side capabilities reader, we should tie this to a capability instead. This has an unfortunate side-effect of making any tenant-level override for the span limit a lie for shared-process tenants. Fixes cockroachdb#93562 Release note: None
|
This change is |
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @stevendanna)
pkg/server/tenant.go line 187 at r1 (raw file):
instanceIDContainer: baseCfg.IDContainer.SwitchToSQLIDContainerForStandaloneSQLInstance(), costControllerFactory: NewTenantSideCostController, spanLimiterFactory: func(ie isql.Executor, st *cluster.Settings, knobs *spanconfig.TestingKnobs) spanconfig.Limiter {
Does spanLimiterFactory: spanconfiglimiter.New not work?
There was a problem hiding this comment.
Reviewable status:
pkg/server/tenant.go line 187 at r1 (raw file):
Previously, knz (Raphael 'kena' Poss) wrote…
Does
spanLimiterFactory: spanconfiglimiter.Newnot work?
spanconfiglimiter.New returns the concrete type.
There was a problem hiding this comment.
Reviewable status:
pkg/server/tenant.go line 187 at r1 (raw file):
Previously, stevendanna (Steven Danna) wrote…
spanconfiglimiter.New returns the concrete type.
Cheers 👍
|
bors r=knz |
|
Build failed (retrying...): |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
|
blathers backport 23.1.0 |
This change installs a noop spanconfig limiter when starting shared-process tenants. Since shared-process tenants are currently used for "unified architecture" in which the tenant is expected to behave as close as possible to the system tenant.
When we have a tenant-side capabilities reader, we should tie this to a capability instead.
This has an unfortunate side-effect of making any tenant-level override for the span limit a lie for shared-process tenants.
Fixes #93562.
Fixes #93561.
Release note: None