-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: kvserver: revert #98150 #99673
Merged
nvanbenschoten
merged 2 commits into
release-22.2
from
blathers/backport-release-22.2-99643
Mar 27, 2023
Merged
release-22.2: kvserver: revert #98150 #99673
nvanbenschoten
merged 2 commits into
release-22.2
from
blathers/backport-release-22.2-99643
Mar 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts #98150 because we think it introduced a problem that was detected via the `replicate/wide` roachtest[^1]. It seems that for reasons still unknown we do rely on the periodic gossip trigger on liveness lease extensions. [^1]: #99268 (comment) Touches #99268. Touches #97966. Closes #99268. Touches #98945. Epic: none Release note: None
blathers-crl
bot
force-pushed
the
blathers/backport-release-22.2-99643
branch
2 times, most recently
from
March 27, 2023 15:49
89a4e20
to
b40d939
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Mar 27, 2023
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
erikgrinaker
approved these changes
Mar 27, 2023
nvanbenschoten
approved these changes
Mar 27, 2023
celiala
pushed a commit
that referenced
this pull request
Mar 27, 2023
…22.2-99643 release-22.2: kvserver: revert #98150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #99643 on behalf of @tbg.
/cc @cockroachdb/release
This reverts #98150 because we think it introduced a problem that was detected
via the
replicate/wide
roachtest1. It seems that for reasons still unknownwe do rely on the periodic gossip trigger on liveness lease extensions.
Touches #99268.
Touches #97966.
Closes #99268.
Touches #98945.
Tracked in #99652.
Epic: none
Release note: None
Release justification: critical bug fix.
Footnotes
roachtest: replicate/wide failed #99268 (comment) ↩