opt: set udf CalledOnNullInput correctly for scalar UDFs #98874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
DrewKimball
force-pushed
the
strict-udf-clarity
branch
from
42698f4 to
b557d7f
Compare
mgartner
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Thanks for clearing this up!
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rharding6373)
rharding6373
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Reviewable status:
Previously, the `UDFPrivate.CalledOnNullInput` field would be set to true for scalar UDFs, since strict behavior is handled using a CASE statement. However, this is confusing and it is also correct to just set `CalledOnNullInput` to the value implied by the function's definition. This patch also adds some detail to the `CalledOnNullInput` comments to indicate when it is used. Informs CRDB-20535 Release note: None
DrewKimball
force-pushed
the
strict-udf-clarity
branch
from
b557d7f to
eb80e5d
Compare
|
TFTRs! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
UDFPrivate.CalledOnNullInputfield would be set to true for scalar UDFs, since strict behavior is handled using a CASE statement. However, this is confusing and it is also correct to just setCalledOnNullInputto the value implied by the function's definition.Informs CRDB-20535
Release note: None