Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logictest: extend temp_table test to exercise discard + drop #96111

Merged

Conversation

ajwerner
Copy link
Contributor

We had bugs with this in earlier releases. This is a forward-port of a test introduced in #96102.

It never failed master, but no reason to ever let this regress.

Epic: none

Release note: None

@ajwerner ajwerner requested a review from a team January 27, 2023 18:31
@cockroach-teamcity
Copy link
Member

This change is Reviewable

We had bugs with this in earlier releases. This is a forward-port of a test
introduced in cockroachdb#96102.

It never failed master, but no reason to ever let this regress.

Epic: none

Release note: None
@ajwerner ajwerner force-pushed the ajwerner/add-temp-table-logic-test branch from e13aa15 to 6619d90 Compare January 27, 2023 18:32
@ajwerner ajwerner changed the title logitctest: extent temp_table test to exercise discard + drop logictest: extent temp_table test to exercise discard + drop Jan 27, 2023
@ajwerner ajwerner changed the title logictest: extent temp_table test to exercise discard + drop logictest: extend temp_table test to exercise discard + drop Jan 27, 2023
Copy link
Collaborator

@ZhouXing19 ZhouXing19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ajwerner
Copy link
Contributor Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 30, 2023

Build failed:

@ajwerner
Copy link
Contributor Author

ajwerner commented Feb 7, 2023

bors r+

@craig craig bot merged commit f640acb into cockroachdb:master Feb 7, 2023
@craig
Copy link
Contributor

craig bot commented Feb 7, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants