From bea38cb136ecdebe594cd106eeeb7170f8767ba2 Mon Sep 17 00:00:00 2001 From: Marcus Gartner Date: Wed, 25 Jan 2023 11:57:40 -0500 Subject: [PATCH] opt: replace make with dev in test instructions Epic: None Release note: None --- pkg/sql/opt/norm/norm_test.go | 6 +++--- pkg/sql/opt/xform/optimizer_test.go | 19 ++++++++++--------- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/pkg/sql/opt/norm/norm_test.go b/pkg/sql/opt/norm/norm_test.go index 5e0a6af6f1b4..8fbf2b3ab86a 100644 --- a/pkg/sql/opt/norm/norm_test.go +++ b/pkg/sql/opt/norm/norm_test.go @@ -36,8 +36,8 @@ import ( // // Rules files can be run separately like this: // -// make test PKG=./pkg/sql/opt/norm TESTS="TestNormRules/bool" -// make test PKG=./pkg/sql/opt/norm TESTS="TestNormRules/comp" +// ./dev test pkg/sql/opt/norm -f TestNormRules/bool +// ./dev test pkg/sql/opt/norm -f TestNormRules/comp // ... func TestNormRules(t *testing.T) { defer leaktest.AfterTest(t)() @@ -58,7 +58,7 @@ func TestNormRules(t *testing.T) { // TestRuleProps files can be run separately like this: // -// make test PKG=./pkg/sql/opt/norm TESTS="TestNormRuleProps/orderings" +// ./dev test pkg/sql/opt/norm -f TestNormRuleProps/orderings // ... func TestNormRuleProps(t *testing.T) { defer leaktest.AfterTest(t)() diff --git a/pkg/sql/opt/xform/optimizer_test.go b/pkg/sql/opt/xform/optimizer_test.go index 403c084e685e..7f36407b4b96 100644 --- a/pkg/sql/opt/xform/optimizer_test.go +++ b/pkg/sql/opt/xform/optimizer_test.go @@ -135,8 +135,8 @@ func TestDetachMemoRace(t *testing.T) { // TestCoster files can be run separately like this: // -// make test PKG=./pkg/sql/opt/xform TESTS="TestCoster/sort" -// make test PKG=./pkg/sql/opt/xform TESTS="TestCoster/scan" +// ./dev test pkg/sql/opt/xform -f TestCoster/sort +// ./dev test pkg/sql/opt/xform -f TestCoster/scan // ... func TestCoster(t *testing.T) { defer leaktest.AfterTest(t)() @@ -150,8 +150,8 @@ func TestCoster(t *testing.T) { // TestPhysicalProps files can be run separately like this: // -// make test PKG=./pkg/sql/opt/xform TESTS="TestPhysicalPropsFactory/ordering" -// make test PKG=./pkg/sql/opt/xform TESTS="TestPhysicalPropsFactory/presentation" +// ./dev test pkg/sql/opt/xform -f TestPhysicalPropsFactory/ordering +// ./dev test pkg/sql/opt/xform -f TestPhysicalPropsFactory/presentation // ... func TestPhysicalProps(t *testing.T) { defer leaktest.AfterTest(t)() @@ -171,7 +171,7 @@ func TestPhysicalProps(t *testing.T) { // TestRuleProps files can be run separately like this: // -// make test PKG=./pkg/sql/opt/xform TESTS="TestRuleProps/orderings" +// ./dev test pkg/sql/opt/xform -f TestRuleProps/orderings // ... func TestRuleProps(t *testing.T) { defer leaktest.AfterTest(t)() @@ -186,8 +186,8 @@ func TestRuleProps(t *testing.T) { // TestRules files can be run separately like this: // -// make test PKG=./pkg/sql/opt/xform TESTS="TestRules/scan" -// make test PKG=./pkg/sql/opt/xform TESTS="TestRules/select" +// ./dev test pkg/sql/opt/xform -f TestRules/scan +// ./dev test pkg/sql/opt/xform -f TestRules/select // ... func TestRules(t *testing.T) { defer leaktest.AfterTest(t)() @@ -211,12 +211,13 @@ var externalTestData = flag.String( // // TestExternal files can be run separately like this: // -// make test PKG=./pkg/sql/opt/xform TESTS="TestExternal/tpch" +// ./dev test pkg/sql/opt/xform -f TestExternal/tpch // ... // // Test files from another location can be run using the -d flag: // -// make test PKG=./pkg/sql/opt/xform TESTS=TestExternal TESTFLAGS='-d /some-dir' +// ./dev test pkg/sql/opt/xform -f TestExternal --rewrite \ +// --test-args="-d=/some-dir" -- --sandbox_writable_path="/some-dir" func TestExternal(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t)