Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: make sure roachprod/roachtest docs use dev, not make #86586

Merged
merged 1 commit into from
Aug 22, 2022
Merged

README: make sure roachprod/roachtest docs use dev, not make #86586

merged 1 commit into from
Aug 22, 2022

Conversation

rickystewart
Copy link
Collaborator

Release justification: Non-production code changes
Release note: None

@rickystewart
README: make sure roachprod/roachtest docs use dev, not make
534bffb 
Release justification: Non-production code changes
Release note: None
@rickystewart rickystewart requested a review from rail August 22, 2022 17:34
@rickystewart rickystewart requested a review from a team as a code owner August 22, 2022 17:34
@rickystewart rickystewart requested review from renatolabs and removed request for a team August 22, 2022 17:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart
Copy link
Collaborator Author

bors r=rail

@msbutler
Copy link
Collaborator

note that a ./dev build -cross does not put the binaries in roachtest's default path. To successfully run the roachtest cmd, I had to run:

roachtest run backupTPCC --cockroach 'artifacts/cockroach'

Perhaps in a follow up PR, we should change roachtest's default path for binaries,

@rickystewart
Copy link
Collaborator Author

@msbutler If you could file an issue for that, that would be great.

@craig
Copy link
Contributor

craig bot commented Aug 22, 2022

Build failed (retrying...):

@msbutler
Copy link
Collaborator

done: #86602

@craig
Copy link
Contributor

craig bot commented Aug 22, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 22, 2022

Build succeeded:

@craig craig bot merged commit 27764b6 into cockroachdb:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rail rail rail approved these changes

@renatolabs renatolabs Awaiting requested review from renatolabs renatolabs is a code owner automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickystewart @cockroach-teamcity @msbutler @rail