Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/builtins: update Info for pg_get_viewdef #86579

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

ZhouXing19
Copy link
Collaborator

The pg_builtin func pg_get_viewdef was updated from a no-op to an actual
function long time ago, but the info field is still notUsableInfo, which
made the doc to miss it by mistake. This PR is to update the info, and let it
be recorded in functions.md.

Release justification: bug fix, update a builtin's visibility in docs.
Release note: none

The pg_builtin func `pg_get_viewdef` was updated from a no-op to an actual
function long time ago, but the info field is still `notUsableInfo`, which
made the doc to miss it by mistake. This PR is to update the info, and let it
be recorded in `functions.md`.

Release justification: bug fix, update a builtin's visibility in docs.
Release note: none
@ZhouXing19 ZhouXing19 requested review from rafiss and a team August 22, 2022 17:11
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@ZhouXing19
Copy link
Collaborator Author

TFTR!
bors r+

@craig
Copy link
Contributor

craig bot commented Aug 22, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 22, 2022

Build succeeded:

@craig craig bot merged commit 27764b6 into cockroachdb:master Aug 22, 2022
@blathers-crl
Copy link

blathers-crl bot commented Aug 22, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from eca9bc9 to blathers/backport-release-21.2-86579: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


error creating merge commit from eca9bc9 to blathers/backport-release-22.1-86579: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants