Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: update styles on sessions details page #86572

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

maryliag
Copy link
Contributor

The Session Details page was updated to use the
same style of summary cards as the other details
pages (e.g. statement, transaction, job).

Fixes #85257

Before
Screen Shot 2022-08-22 at 12 26 43 PM

After
Screen Shot 2022-08-22 at 12 26 19 PM

Release justification: low risk change
Release note (ui change): New styles of summary cards
on Session Details page to align with other details pages.

The Session Details page was updated to use the
same style of summary cards as the other details
pages (e.g. statement, transaction, job).

Fixes cockroachdb#85257

Release justification: low risk change
Release note (ui change): New styles of summary cards
on Session Details page to align with other details pages.
@maryliag maryliag requested a review from a team August 22, 2022 16:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 22, 2022

Build failed:

@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 22, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 22, 2022

Build succeeded:

@craig craig bot merged commit 27764b6 into cockroachdb:master Aug 22, 2022
@maryliag maryliag deleted the sessions-style branch August 22, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

separate summary card fields in Session Details page
3 participants