changefeedccl: unify initial_scan option syntax #79324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
sherman-grewal
force-pushed
the
cdc/unify-initial-scan
branch
3 times, most recently
from
fcf682e to
2753e83
Compare
sherman-grewal
force-pushed
the
cdc/unify-initial-scan
branch
2 times, most recently
from
b04a85a to
f273a7c
Compare
miretskiy
reviewed
Apr 5, 2022
sherman-grewal
force-pushed
the
cdc/unify-initial-scan
branch
from
f273a7c to
7408edc
Compare
Currently, we have explicit options for each possible behaviour that a user would like to achieve for initial scans on changefeeds. For instance, a user could specify: - initial_scan - no_initial_scan - initial_scan_only This seems a bit sprawling, and can inadvertently cause contradictions in a changefeed statement. Hence, in this PR we extend the option `initial_scan` to take on three possible values: `'yes|no|only'`. Once this change is made we will remove the explicit options from the docs, but we will keep these options for backwards compatibility. Release note (enterprise change): Unify the syntax that allows users to define the behaviour they would like for initial scans on changefeeds by extending the `initial_scan` option to take on three possible values: `'yes|no|only'`. Release justification: Small, safe refactor that will improve the user experience when creating changefeeds.
sherman-grewal
force-pushed
the
cdc/unify-initial-scan
branch
from
7408edc to
3f9344f
Compare
miretskiy
approved these changes
Apr 5, 2022
|
bors r+ |
|
bors r- |
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #79324
Currently, we have explicit options for each possible
behaviour that a user would like to achieve for
initial scans on changefeeds. For instance, a user
could specify:
This seems a bit sprawling, and can inadvertently cause
contradictions in a changefeed statement. Hence, in this
PR we extend the option
initial_scanto take on threepossible values:
'yes|no|only'. Once this changeis made we will remove the explicit options from the
docs, but we will keep these options for backwards
compatibility.
Release note (enterprise change): Unify the syntax that
allows users to define the behaviour they would like
for initial scans on changefeeds by extending the
initial_scanoption to take on three possible values:'yes|no|only'.Release justification: Small, safe refactor that will
improve the user experience when creating changefeeds.
Jira issue: CRDB-14693