changefeedccl, backupresolver: refactor to hold on to mapping of target to descriptor #79260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
HonoreDB
force-pushed
the
use_resolver_to_match_descriptors
branch
2 times, most recently
from
d75c933 to
5a4b7fc
Compare
miretskiy
suggested changes
Apr 4, 2022
| @@ -306,7 +306,7 @@ func NewDescriptorResolver(descs []catalog.Descriptor) (*DescriptorResolver, err | |||
| // session database) or if one of its tables matches the targets. All expanded | |||
| // DBs, via either `foo.*` or `DATABASE foo` are noted, as are those explicitly | |||
| // named as DBs (e.g. with `DATABASE foo`, not `foo.*`). These distinctions are | |||
| // used e.g. by RESTORE. | |||
| // used e.g. by RESTORE. tablePatternMap will be populated if non-nil. | |||
There was a problem hiding this comment.
is it really worth it to optimize? Perhaps just return this?
dt
approved these changes
Apr 5, 2022
HonoreDB
force-pushed
the
use_resolver_to_match_descriptors
branch
2 times, most recently
from
0492326 to
37ee373
Compare
…et to descriptor Changefeed statements need to resolve a bunch of table names at once, but unlike backups and grants they need to know which returned descriptor corresponded to which input because they (now) take target-specific options. We were reconstructing this awkwardly on the calling side. This PR adds a DescsByTablePattern map to the backupresolver method being used so that it can track which descriptor belongs to which input. Release note: None
HonoreDB
force-pushed
the
use_resolver_to_match_descriptors
branch
from
37ee373 to
537edf0
Compare
|
Okay, done. |
|
bors r=[miretskiy,dt] |
1 similar comment
|
bors r=[miretskiy,dt] |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changefeed statements need to resolve a bunch of table names at once,
but unlike backups and grants they need to know which returned
descriptor corresponded to which input because they (now) take
target-specific options. We were reconstructing this awkwardly on
the calling side. This PR adds an optional parameter to the
backupresolver method being used so that it can track which
descriptor belongs to which input.
I'm probably being overly polite by making this optional,
but hey, it is a little extra memory footprint and not my package.
Release note: None