cli: order span payloads by start_time for readability #66089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
approved these changes
Jun 7, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @adityamaru)
pkg/cli/debug_job_trace.go, line 103 at r1 (raw file):
WHERE trace_id=$1 ) SELECT * FROM spans, LATERAL (select * from crdb_internal.payloads_for_span(spans.span_id)) ORDER BY spans.start_time`
nit: simpler LATERAL crdb_internal.payloads_for_span(spans.span_id) ORDER BY spans.start_time
During job execution, there can be several root spans on a node. Egs: resumer, processor While the recordings within a span are sorted by start time, since the root spans are stored in an unordered map, the recordings across root spans might not be sorted by start_time. When viewing the output files for a job this results in the processor span printing its payload before the job payload which is not intuitive. We might change how we display recordings in the future, but for the time being this fix makes the "ordering" of events deterministic. Release note: None
adityamaru
force-pushed
the
job-trace-fixup
branch
from
8da1494 to
a3dadd3
Compare
|
TFTR! bors r=knz |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During job execution, there can be several root spans on a node.
Egs: resumer, processor
While the recordings within a span are sorted by start time,
since the root spans are stored in an unordered map, the recordings
across root spans might not be sorted by start_time. When viewing
the output files for a job this results in the processor span printing
its payload before the job payload which is not intuitive.
We might change how we display recordings in the future, but for the
time being this fix makes the "ordering" of events deterministic.
Informs: #64992
Release note: None