catalog: add telemetry for descriptor validation errors #62546
Conversation
|
This change is |
postamar
force-pushed
the
add-validation-telemetry
branch
2 times, most recently
from
3821354 to
c30cfb7
Compare
postamar
force-pushed
the
add-validation-telemetry
branch
2 times, most recently
from
da8a8a0 to
3245ca9
Compare
There was a problem hiding this comment.
Reviewed 5 of 12 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @postamar)
pkg/sql/testdata/telemetry/error, line 70 at r1 (raw file):
errorcodes.22012 # Descriptor validation failure on transaction commit.
any interest in exercising the other telemetry counters you introduced?
This commit adds `sql.schema.validation_errors.*` telemetry keys to descriptor validation errors. Fixes cockroachdb#61786. Release note: None
postamar
force-pushed
the
add-validation-telemetry
branch
from
3245ca9 to
edcf5a8
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/testdata/telemetry/error, line 70 at r1 (raw file):
Previously, ajwerner wrote…
any interest in exercising the other telemetry counters you introduced?
I've added a couple of read counter test cases. To be honest I was struggling in crafting the test cases within the confines of these logic tests. Although, that's rather a good thing, isn't it?
There was a problem hiding this comment.
Reviewed 7 of 12 files at r1, 1 of 1 files at r2.
Reviewable status:
pkg/sql/testdata/telemetry/error, line 70 at r1 (raw file):
Previously, postamar (Marius Posta) wrote…
I've added a couple of read counter test cases. To be honest I was struggling in crafting the test cases within the confines of these logic tests. Although, that's rather a good thing, isn't it?
the unsafe injection with the force flag is a nice big hammer. This works.
|
Thanks for the review! bors r+ |
|
bors r+ |
|
Already running a review |
|
Build succeeded: |
This commit adds
sql.schema.validation_errors.*telemetry keys todescriptor validation errors.
Fixes #61786.
Release note: None