Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dupl Makefile target #3131

Merged
merged 3 commits into from
Nov 13, 2015
Merged

Add dupl Makefile target #3131

merged 3 commits into from
Nov 13, 2015

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Nov 13, 2015

For now, this reports quite a few false positives.

See #2485.

Review on Reviewable

@tamird tamird mentioned this pull request Nov 13, 2015
11 tasks
@tbg
Copy link
Member

tbg commented Nov 13, 2015

was unconvinced this was valuable, but with DUPLFLAGS='-t 100' it actually found some prime targets for easy refactoring = good easy/helpwanted issues. Probably good to have it around.

@tamird
Copy link
Contributor Author

tamird commented Nov 13, 2015

Added a commit with an example such refactor, just so folks have a sense of the kind of stuff this finds. Will merge on green.

@tbg
Copy link
Member

tbg commented Nov 13, 2015

LGTM

On Fri, Nov 13, 2015 at 4:24 PM, Tamir Duberstein [email protected]
wrote:

Added a commit with an example such refactor, just so folks have a sense
of the kind of stuff this finds. Will merge on green.


Reply to this email directly or view it on GitHub
#3131 (comment)
.

tamird added a commit that referenced this pull request Nov 13, 2015
Add `dupl` Makefile target
@tamird tamird merged commit 76d5e10 into cockroachdb:master Nov 13, 2015
@tamird tamird deleted the dupl branch November 13, 2015 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants